--- name: audit-fix-d5ae16891257 description: 审计问题修复技能。读取模块的 AUDIT.md，逐个修复安全/质量问题，修复后归档到 AUDIT_HISTORY.md。严格约束只修改 AUDIT.md 列出的文件。 --- # audit-fix (审计修复) 修复 AUDIT.md 中记录的安全和代码质量问题，保持修改范围最小化。 ## 触发方式 ```bash /audit-fix # 修复指定模块 /audit-fix --issues 1,3,5 # 只修复指定 issue /audit-fix --dry-run # 预览修复计划 /audit-fix --batch # 批量修复指定级别 (critical/high/medium/low) ``` ## 核心约束 ⚠️ **严格限制**: 只能修改 AUDIT.md 列出的文件和行号 ❌ **禁止**: 扩展修改范围、重构其他代码、添加新功能、"顺便"优化 ✅ **允许**: 新增必要的工具函数文件（如 path-utils.js） ## 工作流程 ### Phase 1: 读取审计报告 ```bash # 检查 AUDIT.md 存在 cat /AUDIT.md # 或使用脚本查看 node ~/.claude/skills/project-index/scripts/audit-archive.js --show ``` 解析内容： - Severity 级别 - Issues 列表（每个有 File:Line, Description, Suggestion） ### Phase 2: 逐个修复 对每个 issue： 1. **读取目标文件** - 定位到指定行号 2. **理解问题** - 根据 Description 理解风险 3. **应用修复** - 按 Suggestion 实现，保持最小改动 4. **立即归档** - 修复后立即归档该 issue ```bash # 归档单个 issue node ~/.claude/skills/project-index/scripts/audit-archive.js ``` ### Phase 3: 清理与提交 1. **提交代码** - 只提交修改的源文件（AUDIT.md 被 gitignore） 2. **更新 CLAUDE.md**: - 功能有变化（如新增参数、改变默认行为）→ 修改 CLAUDE.md 内容 - 功能无变化（纯 bug 修复）→ 只需 `touch CLAUDE.md` 更新时间戳 ```bash # 提交格式 git commit -m "fix(): resolve N security audit issues - issue1: - issue2: ... BREAKING: " ``` ## 常见问题类型及修复模式 ### 1. path-traversal (路径穿越) ```javascript // Before const absPath = p.startsWith('/') ? p : `${workDir}/${p}`; // After import path from 'path'; const resolved = path.resolve(workDir, p); if (!resolved.startsWith(workDir + path.sep)) { throw new Error('Path traversal detected'); } ``` ### 2. silent-catch (静默捕获) ```javascript // Before } catch { /* ignore */ } // After } catch (err) { return { error: err.message, available: false }; } ``` ### 3. permission-bypass (权限绕过) ```javascript // Before const defaultHandler = async () => 'allow-once'; // After const defaultHandler = async () => 'deny'; ``` ### 4. browser-compat (浏览器兼容) ```javascript // Before workDir = process.cwd() // After - 要求显式传入 if (!workDir) { throw new Error('workDir is required'); } ``` ### 5. jsdoc (文档缺失) ```javascript // Before export function foo(x, y) { ... } // After /** * Brief description * @param {string} x - Description * @param {number} y - Description * @returns {boolean} Description */ export function foo(x, y) { ... } ``` ### 6. event-naming (事件命名) ```javascript // Before emit('agent.step.completed', data); // After emit('agent:stepCompleted', data); ``` ### 7. timeout-not-enforced (超时未强制) ```javascript // Before const proc = spawn(cmd, args); // After const proc = spawn(cmd, args); const timer = setTimeout(() => proc.kill('SIGTERM'), timeoutMs); proc.on('exit', () => clearTimeout(timer)); ``` ## 批量执行 ### 方式 1: 直接并行 (无 Kanban) 使用 Task 工具并行修复多个模块： ```javascript // Claude 会话中执行（建议 6-8 并发） const modules = ['js/agents/core', 'js/agents/runtime', ...]; // 7 个 Task 工具并行调用，每个 run_in_background: true ``` ### 方式 2: 先导入 Kanban 再批量 ```bash # 1. 导入审计任务到 Kanban node ~/.claude/skills/audit-fix/import-to-kanban.js # 或只导入 CRITICAL node ~/.claude/skills/audit-fix/import-to-kanban.js --severity=critical # 预览模式 node ~/.claude/skills/audit-fix/import-to-kanban.js --dry-run # 2. 查看导入的任务 node ~/.claude/skills/kanban/kanban-cli.js list --status=todo # 3. 批量执行 /kanban-batch --priority=0 ``` ### 检查后台任务进度 ```bash # 查看所有后台任务 ls /tmp/claude/*/tasks/*.output # 查看单个任务输出 tail -50 /tmp/claude/-mnt-f-pb-paper-burner/tasks/.output # 检查审计修复状态 node ~/.claude/skills/project-index/scripts/audit-status.js ``` ## Kanban 集成 审计修复可与 Code Kanban 结合，提供任务追踪和隔离开发环境。 ### 方式 1: CLI 创建任务 ```bash CLI="$HOME/.claude/skills/kanban/kanban-cli.js" # 创建审计任务 node "$CLI" add "[AUDIT] js/agents/core/sandbox/system (7 issues)" \ --priority=0 \ --tags=type/audit,severity/critical \ --description="修复 AUDIT.md 中的 7 个安全问题" # 查看待办 node "$CLI" list --status=todo ``` ### 方式 2: 使用 kanban-implement ```bash # 认领任务并在独立 worktree 中修复 /kanban-implement ``` Worktree 隔离的好处： - 并行修复多个模块互不干扰 - 修复失败可直接丢弃分支 - 便于 code review ### 方式 3: 批量编排 (kanban-batch) ```bash # 把所有 CRITICAL 审计问题导入 Kanban 后 /kanban-batch --priority=0 ``` 自动分析依赖关系，并行执行无依赖的任务。 ### 任务状态更新 ```bash # 开始任务 node "$CLI" start # 完成任务 node "$CLI" done ``` ### 推荐工作流 ``` 1. audit-status.js 检查问题分布 ↓ 2. CLI 创建 Kanban 任务 (P0=CRITICAL, P1=HIGH...) ↓ 3. /kanban-batch 或手动 /kanban-implement ↓ 4. 每个模块修复后： - audit-archive.js 归档 - git commit - node "$CLI" done ``` ## 验证清单 修复完成后检查： - [ ] 所有 issues 已归档 (`--show` 返回 Issues: 0) - [ ] 代码已提交（不含 AUDIT.md） - [ ] CLAUDE.md 时间戳已更新 - [ ] 无引入新的 lint/type 错误 - [ ] Breaking changes 已在 commit message 说明 ## 依赖 - `~/.claude/skills/project-index/scripts/audit-archive.js` - 归档脚本 - `~/.claude/skills/project-index/scripts/audit-status.js` - 状态检查 ## 参考 - `/project-index` - 索引管理 - `/js-agents-entropy-scan` - 生成审计报告 --- Source attribution: David-Li0406 Original project: https://github.com/David-Li0406/meta-skill-evloving/blob/ca3a335628981df10c36e00cb9850df2c247ab9a/skill-flow/data/skills-refined-36k/skillsmp/audit-fix/SKILL.md License: Apache-2.0 License information: https://www.apache.org/licenses/LICENSE-2.0 Original upstream instructions; downloaded from Mega AI Hub. ## Upstream license notice Apache License Version 2.0, January 2004 http://www.apache.org/licenses/ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION 1. Definitions. "License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document. "Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License. "Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity. "You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License. "Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files. "Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types. "Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below). "Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof. "Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution." "Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work. 2. Grant of Copyright License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form. 3. Grant of Patent License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed. 4. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions: (a) You must give any other recipients of the Work or Derivative Works a copy of this License; and (b) You must cause any modified files to carry prominent notices stating that You changed the files; and (c) You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and (d) If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License. 5. Submission of Contributions. Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions. 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file. 7. Disclaimer of Warranty. Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License. 8. Limitation of Liability. In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages. 9. Accepting Warranty or Additional Liability. While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability. END OF TERMS AND CONDITIONS APPENDIX: How to apply the Apache License to your work. To apply the Apache License to your work, attach the following boilerplate notice, with the fields enclosed by brackets "[]" replaced with your own identifying information. (Don't include the brackets!) The text should be enclosed in the appropriate comment syntax for the file format. We also recommend that a file or class name and description of purpose be included on the same "printed page" as the copyright notice for easier identification within third-party archives. Copyright [yyyy] [name of copyright owner] Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. # Mega AI Hub resource metadata Creator / publisher: David-Li0406 Original project: https://github.com/David-Li0406/meta-skill-evloving/blob/ca3a335628981df10c36e00cb9850df2c247ab9a/skill-flow/data/skills-refined-36k/skillsmp/audit-fix/SKILL.md Attribution basis: Source repository record Fields of work: Development & Engineering Roles: Backend Developer, DevOps / SRE, QA / Test Engineer Specialties: Backend, Testing Tools: Kanban Tool, Task Tool Country applicability: Country not specified Classification basis: Source catalog labels Instruction SHA-256: fec4f146b6cec093dbb9f5e747c59950f78027f048aa9c190eb4342a355b1074