--- name: design-patterns-5618acc51803 description: Rust design patterns for RTK. Newtype, Builder, RAII, Trait Objects, State Machine. Applied to CLI filter modules. Use when designing new modules or refactoring existing ones. triggers: - "design pattern" - "how to structure" - "best pattern for" - "refactor to pattern" allowed-tools: - Read - Grep - Glob effort: medium tags: [rust, design-patterns, architecture, newtype, builder, rtk] --- # RTK Rust Design Patterns Patterns that apply to RTK's filter module architecture. Focused on CLI tool patterns, not web/service patterns. ## Pattern 1: Newtype (Type Safety) Use when: wrapping primitive types to prevent misuse (command names, paths, token counts). ```rust // Without Newtype — easy to mix up fn track(input_tokens: usize, output_tokens: usize) { ... } track(output_tokens, input_tokens); // Silent bug! // With Newtype — compile error on swap pub struct InputTokens(pub usize); pub struct OutputTokens(pub usize); fn track(input: InputTokens, output: OutputTokens) { ... } track(OutputTokens(100), InputTokens(400)); // Compile error ✅ ``` ```rust // Practical RTK example: command name validation pub struct CommandName(String); impl CommandName { pub fn new(s: &str) -> Result { if s.contains(';') || s.contains('|') || s.contains('`') { anyhow::bail!("Invalid command name: shell metacharacters"); } Ok(Self(s.to_string())) } pub fn as_str(&self) -> &str { &self.0 } } ``` ## Pattern 2: Builder (Complex Configuration) Use when: a struct has 4+ optional fields, many with defaults. ```rust #[derive(Default)] pub struct FilterConfig { max_lines: Option, strip_ansi: bool, show_warnings: bool, truncate_at: Option, } impl FilterConfig { pub fn new() -> Self { Self::default() } pub fn max_lines(mut self, n: usize) -> Self { self.max_lines = Some(n); self } pub fn strip_ansi(mut self, v: bool) -> Self { self.strip_ansi = v; self } pub fn show_warnings(mut self, v: bool) -> Self { self.show_warnings = v; self } } // Usage — readable, no positional arg confusion let config = FilterConfig::new() .max_lines(50) .strip_ansi(true) .show_warnings(false); ``` When NOT to use Builder: if the struct has 1-3 fields with obvious meaning. Over-engineering for simple cases. ## Pattern 3: State Machine (Parser/Filter Flows) Use when: parsing multi-section output (test results, build output) where context changes behavior. ```rust // RTK example: pytest output parsing #[derive(Debug, PartialEq)] enum ParseState { LookingForTests, InTestOutput, InFailureSummary, Done, } fn parse_pytest(input: &str) -> String { let mut state = ParseState::LookingForTests; let mut failures = Vec::new(); for line in input.lines() { match state { ParseState::LookingForTests => { if line.contains("FAILED") || line.contains("ERROR") { state = ParseState::InFailureSummary; failures.push(line); } } ParseState::InFailureSummary => { if line.starts_with("=====") { state = ParseState::Done; } else { failures.push(line); } } ParseState::Done => break, _ => {} } } failures.join("\n") } ``` ## Pattern 4: Trait Object (Command Dispatch) Use when: different command families need the same interface. Avoids massive match arms. ```rust // Define a common interface for filters pub trait OutputFilter { fn filter(&self, input: &str) -> Result; fn command_name(&self) -> &str; } pub struct GitFilter; pub struct CargoFilter; impl OutputFilter for GitFilter { fn filter(&self, input: &str) -> Result { filter_git(input) } fn command_name(&self) -> &str { "git" } } // RTK currently uses match-based dispatch in main.rs (simpler, no dynamic dispatch overhead) // Trait objects are useful if filter registry becomes dynamic (e.g., TOML-loaded plugins) ``` Note: RTK's current `match` dispatch in `main.rs` is intentional — static dispatch, zero overhead. Only move to trait objects if the match arm count exceeds ~20 commands. ## Pattern 5: RAII (Resource Management) Use when: managing resources that need cleanup (temp files, SQLite connections). ```rust // RTK tee.rs — RAII for temp output files pub struct TeeFile { path: PathBuf, } impl TeeFile { pub fn create(content: &str) -> Result { let path = tee_path()?; fs::write(&path, content) .with_context(|| format!("Failed to write tee file: {}", path.display()))?; Ok(Self { path }) } pub fn path(&self) -> &Path { &self.path } } // No explicit cleanup needed — file persists intentionally (rotation handled separately) // If cleanup were needed: impl Drop { fn drop(&mut self) { let _ = fs::remove_file(&self.path); } } ``` ## Pattern 6: Strategy (Swappable Filter Logic) Use when: a command has multiple filtering modes (e.g., compact vs. verbose). ```rust pub enum FilterMode { Compact, // Show only failures/errors Summary, // Show counts + top errors Full, // Pass through unchanged } pub fn apply_filter(input: &str, mode: FilterMode) -> String { match mode { FilterMode::Compact => filter_compact(input), FilterMode::Summary => filter_summary(input), FilterMode::Full => input.to_string(), } } ``` ## Pattern 7: Extension Trait (Add Methods to External Types) Use when: you need to add methods to types you don't own (like `&str` for RTK-specific parsing). ```rust pub trait RtkStrExt { fn is_error_line(&self) -> bool; fn is_warning_line(&self) -> bool; fn token_count(&self) -> usize; } impl RtkStrExt for str { fn is_error_line(&self) -> bool { self.starts_with("error") || self.contains("[E") } fn is_warning_line(&self) -> bool { self.starts_with("warning") } fn token_count(&self) -> usize { self.split_whitespace().count() } } // Usage if line.is_error_line() { ... } let tokens = output.token_count(); ``` ## RTK Pattern Selection Guide | Situation | Pattern | Avoid | |-----------|---------|-------| | New `*_cmd.rs` filter module | Standard module pattern (see CLAUDE.md) | Over-abstracting | | 4+ optional config fields | Builder | Struct literal | | Multi-phase output parsing | State Machine | Nested if/else | | Type-safe wrapper around string | Newtype | Raw `String` | | Adding methods to `&str` | Extension Trait | Free functions | | Resource with cleanup | RAII / Drop | Manual cleanup | | Dynamic filter registry | Trait Object | Match sprawl | ## Anti-Patterns in RTK Context ```rust // ❌ Generic over-engineering for one command pub trait Filterable { ... } // ✅ Just write the function pub fn filter_git_log(input: &str) -> Result { ... } // ❌ Singleton registry with global state static FILTER_REGISTRY: Mutex>> = ...; // ✅ Match in main.rs — simple, zero overhead, easy to trace // ❌ Async traits for "future-proofing" #[async_trait] pub trait Filter { async fn apply(&self, input: &str) -> Result; } // ✅ Synchronous — RTK is single-threaded by design pub trait Filter { fn apply(&self, input: &str) -> Result; } ``` --- Source attribution: roberttmadsen13-del Original project: https://github.com/roberttmadsen13-del/TOURney/blob/887b95224dcc4b9c0a60f25230c5faa7105a4d1f/SKILLS/rtk-master/.claude/skills/design-patterns/SKILL.md License: Apache-2.0 License information: https://www.apache.org/licenses/LICENSE-2.0 Original upstream instructions; downloaded from Mega AI Hub. ## Upstream license notice Apache License Version 2.0, January 2004 http://www.apache.org/licenses/ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION 1. Definitions. "License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document. "Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License. "Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity. "You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License. "Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files. "Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types. "Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below). "Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof. "Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution." "Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work. 2. Grant of Copyright License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form. 3. Grant of Patent License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed. 4. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions: (a) You must give any other recipients of the Work or Derivative Works a copy of this License; and (b) You must cause any modified files to carry prominent notices stating that You changed the files; and (c) You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and (d) If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License. 5. Submission of Contributions. Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions. 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file. 7. Disclaimer of Warranty. Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License. 8. Limitation of Liability. In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages. 9. Accepting Warranty or Additional Liability. While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability. END OF TERMS AND CONDITIONS Copyright 2024 rtk-ai and rtk-ai Labs Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. # Mega AI Hub resource metadata Creator / publisher: roberttmadsen13-del Original project: https://github.com/roberttmadsen13-del/TOURney/blob/887b95224dcc4b9c0a60f25230c5faa7105a4d1f/SKILLS/rtk-master/.claude/skills/design-patterns/SKILL.md Attribution basis: Source repository record Fields of work: Development & Engineering, Product Management Roles: Backend Developer, Product Manager, Technical Product Manager Specialties: Backend Tools: Rust Country applicability: Country not specified Classification basis: Source catalog labels Instruction SHA-256: e91f3798853cb443441b752fd018db5c4ded8934e9dead91d11a0d8203a59b83