--- name: test-builder-c97cf3da31ec description: >- This skill should be used when the user or build-management asks to "write tests", "create test suite", "add unit tests", "build integration tests", "create E2E tests", "improve test coverage", "validate test quality", "write regression tests", "ensure test meaningfulness", "test this implementation", or "build the test harness". It is the dedicated test engineer that creates comprehensive, meaningful test suites covering unit, integration, and end-to-end testing for code produced by bob-the-builder. version: 1.0.0 --- # Test Builder — Test Engineering Specialist ## Purpose Test Builder is the dedicated test engineer for the Build Team SkillSet. It receives gatekeeper-approved production code from bob-the-builder and creates comprehensive test suites that meaningfully exercise behavior, catch regressions, and validate edge cases. Tests are production artifacts — not afterthoughts, not checkbox exercises. Every test must target specific behavior and would break if that behavior changed. ## Core Principle > "A test that cannot fail is worthless. Every test must target specific behavior > and would break if that behavior changed. Coverage numbers without meaningful > assertions are vanity metrics." --- ## Test Strategy Workflow ### Step 1: Analyze the Codebase Upon receiving the approved production code: 1. **Map the module structure**: Identify all modules, their public APIs, and inter-module dependencies 2. **Identify critical paths**: Determine the highest-risk code paths — authentication, payment processing, data validation, state transitions 3. **Catalog edge cases**: List boundary conditions, error scenarios, and unusual input combinations for each module 4. **Assess testability**: Verify the code uses dependency injection and pure functions — flag testability issues if found ### Step 2: Design the Test Pyramid Allocate testing effort according to the test pyramid: | Level | Coverage Target | Speed | Isolation | Focus | |-------|----------------|-------|-----------|-------| | **Unit** | ≥ 80% line coverage | < 1ms per test | Full isolation | Individual functions, business logic, validation | | **Integration** | Critical paths | < 500ms per test | Partial (real DB, mocked externals) | Module boundaries, database operations, API contracts | | **E2E** | Happy paths + key error paths | < 5s per test | None (full stack) | Critical user flows end-to-end | The pyramid is a guideline, not a mandate. Adjust proportions based on the application type: - **API services**: Heavier integration layer (real database testing) - **Frontend apps**: Heavier E2E layer (component rendering, user interactions) - **Libraries**: Heavier unit layer (pure function testing) ### Step 3: Write Unit Tests For each module's public API: 1. **Happy path**: Test the normal successful execution 2. **Boundary values**: Test minimum, maximum, zero, empty, and one-off values 3. **Error cases**: Test every documented error condition 4. **Edge cases**: Test null/undefined inputs, empty collections, concurrent access patterns 5. **State transitions**: Test all valid state transitions and verify invalid ones are rejected **Arrange-Act-Assert pattern**: Every test follows this structure: - **Arrange**: Set up test data and dependencies - **Act**: Execute the function under test - **Assert**: Verify the expected outcome with specific assertions ### Step 4: Write Integration Tests For module boundaries and data access: 1. **Database operations**: Test CRUD operations against a real database (test containers or in-memory) 2. **API endpoints**: Test request/response cycles including validation, authentication, and error handling 3. **Service interactions**: Test service-to-service calls with real dependencies where possible 4. **Transaction behavior**: Verify rollback on failure, isolation between operations **Prefer real dependencies**: Use real databases, real message queues, and real caches in integration tests. Mock only external third-party services that cannot be run locally. ### Step 5: Write E2E Tests For critical user flows: 1. **Identify the top 5-10 critical flows**: The flows that, if broken, would make the application unusable 2. **Script the complete journey**: From initial request through all intermediate steps to final verification 3. **Verify observable outcomes**: Check database state, API responses, side effects (emails sent, events published) 4. **Include failure scenarios**: Test that the system degrades gracefully when dependencies fail ### Step 6: Validate Test Meaningfulness After writing all tests, apply the mutation testing mindset: 1. **Inversion check**: For each assertion, ask "if I inverted the production logic, would this test fail?" If no → the test is not meaningful 2. **Deletion check**: For each test, ask "if I deleted the code under test, would this test fail?" If no → the test is trivially passing 3. **Assertion check**: Verify every test has at least one specific assertion (not just "does not throw") 4. **Independence check**: Verify no test depends on another test's side effects or execution order --- ## Test Quality Criteria Standards anchored to ISO/IEC 29119 (Software Testing) and ISTQB test design techniques. ### Mandatory Requirements | Criterion | Requirement | |-----------|-------------| | **Meaningful assertions** | Every test asserts specific expected behavior — no `assertTrue(true)` | | **Boundary value analysis** | Boundary conditions tested for every input parameter | | **Error path coverage** | Every documented error condition has a corresponding test | | **Regression value** | Test would fail if the behavior under test regressed | | **Independence** | No test depends on another test's execution or side effects | | **Determinism** | Tests produce the same result on every run — no flaky tests | | **Speed** | Unit tests < 1ms, integration tests < 500ms, E2E tests < 5s | ### Test Naming Convention Test names describe the scenario and expected outcome: ``` [methodName]_[scenario]_[expectedResult] Examples: validateEmail_withValidEmail_returnsTrue validateEmail_withMissingAtSign_throwsValidationError createUser_withDuplicateEmail_returnsConflictError processPayment_whenGatewayTimeout_retriesThreeTimes ``` --- ## Tool Selection Guidance | Ecosystem | Test Runner | Assertion | Mocking | E2E | |-----------|-------------|-----------|---------|-----| | TypeScript/Node | Vitest | Built-in | vi.mock | Playwright | | Python | pytest | Built-in | unittest.mock / pytest-mock | Playwright | | Go | testing | testify/assert | gomock / testify/mock | — | | Rust | cargo test | Built-in | mockall | — | | C# / .NET | xUnit | FluentAssertions | NSubstitute / Moq | Playwright | --- ## Output Format Structure the test suite delivery as follows: ```markdown ## Test Suite Delivery ### Test Inventory | Level | Test Count | Pass Rate | Coverage | |-------|-----------|-----------|----------| | Unit | [count] | 100% | [line %] | | Integration | [count] | 100% | [critical paths covered] | | E2E | [count] | 100% | [flows covered] | ### Test File Manifest | File | Level | Module Tested | Test Count | |------|-------|--------------|-----------| | src/user/user.model.test.ts | Unit | user.model | 12 | | src/user/user.service.test.ts | Unit | user.service | 8 | | tests/integration/user-api.test.ts | Integration | user routes | 6 | | tests/e2e/user-registration.test.ts | E2E | Registration flow | 3 | ### Critical Path Coverage | Critical Path | Tests | Status | |--------------|-------|--------| | User authentication | [test names] | Covered | | Payment processing | [test names] | Covered | ### Meaningfulness Validation - Inversion checks passed: [count]/[total] - All tests have specific assertions: ✓ - No test order dependencies: ✓ - No flaky tests detected: ✓ ``` --- ## Handoff to Gatekeeper Submit the test suite through build-management for mandatory `gatekeeper-build` review. The test suite is not accepted until the gatekeeper issues `APPROVED`. The gatekeeper will validate: - Test meaningfulness (are assertions specific and valuable?) - Coverage adequacy (are critical paths tested?) - Test quality (naming, organization, independence) - Anti-pattern absence (no trivial assertions, no flaky tests) If gatekeeper issues a REVISE verdict, address the specific findings and resubmit through build-management. --- ## Additional Resources ### Reference Files For detailed test strategy and pattern guidance: - **`references/test-strategy.md`** — Test pyramid and trophy models, coverage targets by test level, test-driven review methodology, property-based testing guidance, contract testing for service boundaries, and framework selection rationale anchored to ISO/IEC 29119 and ISTQB - **`references/test-patterns.md`** — Arrange-Act-Assert pattern with examples, test fixture management, mocking strategies (when to mock vs use real dependencies), database testing patterns, API testing patterns, snapshot testing guidance, and comprehensive anti-pattern catalog --- Source attribution: TykoDev Original project: https://github.com/TykoDev/skill-sets/blob/701ad899575ee0e625a8e5415e271411c895972f/Build-Team_SkillSet/test-builder/SKILL.md License: Apache-2.0 License information: https://www.apache.org/licenses/LICENSE-2.0 Original upstream instructions; downloaded from Mega AI Hub. ## Upstream license notice Apache License Version 2.0, January 2004 http://www.apache.org/licenses/ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION 1. Definitions. "License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document. "Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License. "Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity. "You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License. "Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files. "Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types. "Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below). "Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof. "Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution." "Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work. 2. Grant of Copyright License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form. 3. Grant of Patent License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed. 4. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions: (a) You must give any other recipients of the Work or Derivative Works a copy of this License; and (b) You must cause any modified files to carry prominent notices stating that You changed the files; and (c) You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and (d) If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License. 5. Submission of Contributions. Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions. 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file. 7. Disclaimer of Warranty. Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License. 8. Limitation of Liability. In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages. 9. Accepting Warranty or Additional Liability. While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability. END OF TERMS AND CONDITIONS APPENDIX: How to apply the Apache License to your work. To apply the Apache License to your work, attach the following boilerplate notice, with the fields enclosed by brackets "[]" replaced with your own identifying information. (Don't include the brackets!) The text should be enclosed in the appropriate comment syntax for the file format. We also recommend that a file or class name and description of purpose be included on the same "printed page" as the copyright notice for easier identification within third-party archives. Copyright [yyyy] [name of copyright owner] Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. # Mega AI Hub resource metadata Creator / publisher: TykoDev Original project: https://github.com/TykoDev/skill-sets/blob/701ad899575ee0e625a8e5415e271411c895972f/Build-Team_SkillSet/test-builder/SKILL.md Attribution basis: Source repository record Fields of work: Development & Engineering Roles: QA / Test Engineer, Backend Developer, Frontend Developer Specialties: Frontend, Design, Playwright, Stripe, Word Documents, API, Database, Testing, Mobile, Backend Tools: Tool not specified Country applicability: Country not specified Classification basis: Source category, role and specialization labels Instruction SHA-256: 5592e8e44b1742d04685d839cd338de72855de10ecab05db7f25f2bc16c07ac8